Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/322#discussion_r22341017
--- Diff: tajo-plan/src/main/proto/Plan.proto ---
@@ -26,58 +26,280 @@ import "CatalogProtos.proto";
import "DataTypes.proto";
enum NodeType {
- BST_INDEX_SCAN = 0;
- EXCEPT = 1;
+ SET_SESSION = 0;
+
+ ROOT = 1;
EXPRS = 2;
- DISTINCT_GROUP_BY = 3;
- GROUP_BY = 4;
- HAVING = 5;
- JOIN = 6;
- INSERT = 7;
- INTERSECT = 8;
- LIMIT = 9;
- PARTITIONS_SCAN = 10;
- PROJECTION = 11;
- ROOT = 12;
- SCAN = 13;
- SELECTION = 14;
- SORT = 15;
- STORE = 16;
- TABLE_SUBQUERY = 17;
- UNION = 18;
- WINDOW_AGG = 19;
-
- CREATE_DATABASE = 20;
- DROP_DATABASE = 21;
- CREATE_TABLE = 22;
- DROP_TABLE = 23;
- ALTER_TABLESPACE = 24;
- ALTER_TABLE = 25;
- TRUNCATE_TABLE = 26;
-}
-
-message LogicalPlan {
- required KeyValueSetProto adjacentList = 1;
+ PROJECTION = 3;
+ LIMIT = 4;
+ WINDOW_AGG = 5;
+ SORT = 6;
+ HAVING = 7;
+ GROUP_BY = 8;
+ DISTINCT_GROUP_BY = 9;
+ SELECTION = 10;
+ JOIN = 11;
+ UNION = 12;
+ INTERSECT = 13;
+ EXCEPT = 14;
+ TABLE_SUBQUERY = 15;
+ SCAN = 16;
+ PARTITIONS_SCAN = 17;
+ BST_INDEX_SCAN = 18;
+ STORE = 19;
+ INSERT = 20;
+
+ CREATE_DATABASE = 21;
+ DROP_DATABASE = 22;
+ CREATE_TABLE = 23;
+ DROP_TABLE = 24;
+ ALTER_TABLESPACE = 25;
+ ALTER_TABLE = 26;
+ TRUNCATE_TABLE = 27;
}
-message LogicalNode {
- required int32 pid = 1;
- required NodeType type = 2;
- required SchemaProto in_schema = 3;
- required SchemaProto out_schema = 4;
- required NodeSpec spec = 5;
+message LogicalNodeTree {
+ repeated LogicalNode nodes = 1;
}
-message NodeSpec {
- optional ScanNode scan = 1;
+message LogicalNode {
+ required int32 sid = 1;
--- End diff --
The names of ```sid``` and ```pid``` are hard to guess their meanings.
Would you add some comments?
It would be better if you can change these names to be more expressible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
