Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/364#discussion_r23673538
--- Diff:
tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java ---
@@ -725,13 +725,8 @@ public static void
scheduleRangeShuffledFetches(TaskSchedulerContext schedulerCo
}
}
- boolean ascendingFirstKey = sortSpecs[0].isAscending();
SortedMap<TupleRange, Collection<FetchImpl>> map;
- if (ascendingFirstKey) {
- map = new TreeMap<TupleRange, Collection<FetchImpl>>();
- } else {
- map = new TreeMap<TupleRange, Collection<FetchImpl>>(new
TupleRange.DescendingTupleRangeComparator());
--- End diff --
This patch looks good to me.
@hyunsik and @jihoonson Do we have any reason to keep the descending
ranges ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
