Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/364#discussion_r23840362
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java ---
    @@ -740,7 +735,7 @@ public static void 
scheduleRangeShuffledFetches(TaskSchedulerContext schedulerCo
             fetchSet = new HashSet<FetchImpl>();
             for (FetchImpl fetch: fetches) {
               String rangeParam =
    -              TupleUtil.rangeToQuery(ranges[i], ascendingFirstKey ? i == 
(ranges.length - 1) : i == 0, encoder);
    --- End diff --
    
    @sirpkt 
    I have heard from hyunsik that descending order consider the sampling and 
limit clause.
    In my opinion, main bug fixing  is good. 
    The range array is ascending. so {{ascendingFirstKey}} checking do not need
    ```
    TupleUtil.rangeToQuery(ranges[i], i == (ranges.length - 1), encoder);
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to