[ 
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328520#comment-14328520
 ] 

ASF GitHub Bot commented on TAJO-1350:
--------------------------------------

GitHub user jihoonson opened a pull request:

    https://github.com/apache/tajo/pull/384

    TAJO-1350: Refactor FilterPushDownRule::visitJoin() into well-defined, 
small methods

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jihoonson/tajo-2 TAJO-1350

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #384
    
----
commit cf960f99212ebd7c631071af7508036f70e0a210
Author: Jihoon Son <[email protected]>
Date:   2015-02-19T12:57:04Z

    TAJO-1350

commit 1bf85f60280dcaeb8b14323530bf3c9fd6b9aba6
Author: Jihoon Son <[email protected]>
Date:   2015-02-20T03:13:22Z

    TAJO-1350

commit 5a4e55531aa1c797eead8a940138f61d79ccc0be
Author: Jihoon Son <[email protected]>
Date:   2015-02-20T03:23:39Z

    TAJO-1350

commit 1bad40b88719da67adf3aa5c103879135f536aee
Author: Jihoon Son <[email protected]>
Date:   2015-02-20T03:46:15Z

    TAJO-1350

commit 8b1cd6441ebe6794a3675bd4a64b652af82f4356
Author: Jihoon Son <[email protected]>
Date:   2015-02-20T03:52:21Z

    TAJO-1350

----


> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
>                 Key: TAJO-1350
>                 URL: https://issues.apache.org/jira/browse/TAJO-1350
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Jihoon Son
>             Fix For: 0.11
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles 
> various cases in a single method. We need to refactor this method into 
> several small and well-defined methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to