[
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349553#comment-14349553
]
ASF GitHub Bot commented on TAJO-1350:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/384#discussion_r25909557
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
---
@@ -1963,7 +1964,7 @@ public static boolean
checkIfBeEvaluatedAtGroupBy(EvalNode evalNode, GroupbyNode
}
public static boolean checkIfBeEvaluatedAtJoin(QueryBlock block,
EvalNode evalNode, JoinNode node,
- boolean isTopMostJoin) {
+ boolean isOnPredicate) {
--- End diff --
```isOnPredicate``` seems to be a flag to indicate if a predicate is ON
clause?
But, it seems to be inconsistent with its usecases. In
ProjectionPushDownRule, TRUE is given to this parameter. But, in the line 1153,
this value is true even though they are not placed ON clause.
Could you let me know your exact intention about this change?
> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
> Key: TAJO-1350
> URL: https://issues.apache.org/jira/browse/TAJO-1350
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Jihoon Son
> Fix For: 0.11
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles
> various cases in a single method. We need to refactor this method into
> several small and well-defined methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
