[
https://issues.apache.org/jira/browse/TAJO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344418#comment-14344418
]
ASF GitHub Bot commented on TAJO-527:
-------------------------------------
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r25660324
--- Diff:
tajo-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedFileRegion.java
---
@@ -158,9 +160,9 @@ public void releaseExternalResources() {
* we don't need the region to be cached anymore.
*/
public void transferSuccessful() {
- if (PullServerUtil.isNativeIOPossible() && manageOsCache && getCount()
> 0) {
+ if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() >
0) {
--- End diff --
Can you add file checking ?
if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() > 0 &&
super.isOpen())
It will fix the "bad file descriptor"
```
2015-03-03 10:34:40,755 WARN org.apache.tajo.pullserver.PullServerUtil:
Failed to manage OS cache for
/data05/tajo/data/q_1425346386770_0001/output/1/hash-shuffle/3/263
java.lang.NullPointerException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.apache.tajo.pullserver.PullServerUtil.posixFadviseIfPossible(PullServerUtil.java:56)
at
org.apache.tajo.pullserver.FadvisedFileRegion.transferSuccessful(FadvisedFileRegion.java:163)
at
org.apache.tajo.pullserver.FileCloseListener.operationComplete(FileCloseListener.java:46)
```
> Upgrade to Netty 4
> ------------------
>
> Key: TAJO-527
> URL: https://issues.apache.org/jira/browse/TAJO-527
> Project: Tajo
> Issue Type: Improvement
> Components: rpc
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
>
> Currently, rpc package uses Netty 3. Netty 4 is more stable and will get
> significant performance benefits. We need to upgrade Netty version to 4.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
