[
https://issues.apache.org/jira/browse/TAJO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344558#comment-14344558
]
ASF GitHub Bot commented on TAJO-527:
-------------------------------------
Github user ykrips commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r25664051
--- Diff:
tajo-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedFileRegion.java
---
@@ -158,9 +160,9 @@ public void releaseExternalResources() {
* we don't need the region to be cached anymore.
*/
public void transferSuccessful() {
- if (PullServerUtil.isNativeIOPossible() && manageOsCache && getCount()
> 0) {
+ if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() >
0) {
--- End diff --
Interesting... Netty team added isOpen() api on DefaultFileRegion class in
4.0.25.final. It could be good to use netty api for checking if this fileregion
is deallocated or not.
> Upgrade to Netty 4
> ------------------
>
> Key: TAJO-527
> URL: https://issues.apache.org/jira/browse/TAJO-527
> Project: Tajo
> Issue Type: Improvement
> Components: rpc
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
>
> Currently, rpc package uses Netty 3. Netty 4 is more stable and will get
> significant performance benefits. We need to upgrade Netty version to 4.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
