[ 
https://issues.apache.org/jira/browse/TAJO-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357213#comment-14357213
 ] 

ASF GitHub Bot commented on TAJO-1360:
--------------------------------------

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/413

    TAJO-1360: VALUES_ field in OPTIONS table of catalog store should be longer.

    I suggest OPTIONS size as 4000, because max size of  oracle varchar2 is 
just 4000
    I researched docs for these patch.
    
    maria: https://mariadb.com/kb/en/mariadb/varchar/
    mysql: http://dev.mysql.com/doc/refman/5.7/en/char.html
    postgres: http://www.postgresql.org/docs/8.3/static/datatype-character.html
    derby: https://db.apache.org/derby/docs/10.7/ref/rrefsqlj41207.html
    oracle: 
https://docs.oracle.com/cd/B28359_01/server.111/b28320/limits001.htm#i287903
    (here varchar2 limit is just 4000)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/TAJO-1360

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/413.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #413
    
----
commit 031d6e6f4d023ed9e014635d718239bf0291f625
Author: clark.kang <[email protected]>
Date:   2015-03-11T15:48:45Z

    TAJO-1360

----


> VALUES_ field in OPTIONS table of catalog store should be longer.
> -----------------------------------------------------------------
>
>                 Key: TAJO-1360
>                 URL: https://issues.apache.org/jira/browse/TAJO-1360
>             Project: Tajo
>          Issue Type: Bug
>          Components: catalog
>            Reporter: Hyunsik Choi
>             Fix For: 0.11
>
>
> Table properties for each table are maintained in {{OPTIONS}} table in 
> catalog store. Each key and value for each table property use {{KEY_}} and 
> {{VALUE_}} fields as follows:
> {code}
> CREATE TABLE OPTIONS (
>   TID INT NOT NULL,
>   KEY_ VARCHAR(255) BINARY NOT NULL,
>   VALUE_ VARCHAR(255) NOT NULL,
>   PRIMARY KEY (TID, KEY_),
>   FOREIGN KEY (TID) REFERENCES TABLES (TID) ON DELETE CASCADE
> )
> {code}
> Newly adopted Hbase storage uses the table property {{columns}}  to maintain 
> the column map between a HBase table and Tajo table. {{VALUE_}} is likely to 
> cause 'Data too long' exception because its maximum length is just 256.
> So, we need to increase the maximum size. I think that 8000 would be proper 
> because some RDBMSs supports VARCHAR types up to 8000 chars as far as I know.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to