[
https://issues.apache.org/jira/browse/TAJO-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357890#comment-14357890
]
ASF GitHub Bot commented on TAJO-1360:
--------------------------------------
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/413#issuecomment-78404355
Since I did move sql statements to xml files for Oracle and PostgreSQL
DBMS, but these deprecated sql files for Oracle and PostgreSQL are still
remained. Sorry for that. Can you apply these changes to
/tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml
and
/tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml?
I will create another issue to delete these deprecated sql files. Without this
issue, I don't have any concerns on this patch.
> VALUES_ field in OPTIONS table of catalog store should be longer.
> -----------------------------------------------------------------
>
> Key: TAJO-1360
> URL: https://issues.apache.org/jira/browse/TAJO-1360
> Project: Tajo
> Issue Type: Bug
> Components: catalog
> Reporter: Hyunsik Choi
> Assignee: DaeMyung Kang
> Fix For: 0.11
>
>
> Table properties for each table are maintained in {{OPTIONS}} table in
> catalog store. Each key and value for each table property use {{KEY_}} and
> {{VALUE_}} fields as follows:
> {code}
> CREATE TABLE OPTIONS (
> TID INT NOT NULL,
> KEY_ VARCHAR(255) BINARY NOT NULL,
> VALUE_ VARCHAR(255) NOT NULL,
> PRIMARY KEY (TID, KEY_),
> FOREIGN KEY (TID) REFERENCES TABLES (TID) ON DELETE CASCADE
> )
> {code}
> Newly adopted Hbase storage uses the table property {{columns}} to maintain
> the column map between a HBase table and Tajo table. {{VALUE_}} is likely to
> cause 'Data too long' exception because its maximum length is just 256.
> So, we need to increase the maximum size. I think that 8000 would be proper
> because some RDBMSs supports VARCHAR types up to 8000 chars as far as I know.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
