[ 
https://issues.apache.org/jira/browse/TAJO-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375936#comment-14375936
 ] 

ASF GitHub Bot commented on TAJO-1284:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/448#discussion_r26939171
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto ---
    @@ -293,10 +293,21 @@ message PartitionMethodProto {
     }
     
     message PartitionDescProto {
    -  optional string partitionName = 2;
    -  required int32  ordinalPosition = 3;
    -  optional string partitionValue = 4;
    -  optional string path = 5;
    +  required string partitionName = 1;
    +  repeated PartitionKeyProto partitionKeys = 32;
    --- End diff --
    
    This will not induce any problems, but it would be better to change to 2.


> Add alter partition method to CatalogStore
> ------------------------------------------
>
>                 Key: TAJO-1284
>                 URL: https://issues.apache.org/jira/browse/TAJO-1284
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: catalog
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>         Attachments: TAJO-1260.png, TAJO-1260.sql, TAJO-1284.patch, 
> TAJO-1284_2.png, TAJO-1284_2.sql
>
>
> This patch will implement  ALTER TABLE ADD PARTITION method and ALTER TABLE 
> DROP PARTITION method to CatalogStore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to