[jira] [Commented] (TAJO-1284) Add alter partition method to CatalogStore

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377788#comment-14377788
 ] 

ASF GitHub Bot commented on TAJO-1284:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/448#discussion_r27023446
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java
 ---
    @@ -50,15 +73,21 @@ public PartitionDesc(CatalogProtos.PartitionDescProto 
proto) {
         if(proto.hasPartitionName()) {
           this.partitionName = proto.getPartitionName();
         }
    -    this.ordinalPosition = proto.getOrdinalPosition();
    -    if(proto.hasPartitionValue()) {
    -      this.partitionValue = proto.getPartitionValue();
    +
    +    this.partitionKeys = new ArrayList<PartitionKey>();
    +    for(CatalogProtos.PartitionKeyProto keyProto : 
proto.getPartitionKeysList()) {
    +      PartitionKey partitionKey = new PartitionKey(keyProto);
    +      this.partitionKeys.add(partitionKey);
         }
    +
         if(proto.hasPath()) {
           this.path = proto.getPath();
         }
       }
     
    +  public String getPartitionName() { return partitionName; }
    +  public void setPartitionName(String partitionName) { this.partitionName 
= partitionName; }
    --- End diff --
    
    Is this function different with the below setName() function?
    In addition, please move brackets according to our coding convention.


> Add alter partition method to CatalogStore
> ------------------------------------------
>
>                 Key: TAJO-1284
>                 URL: https://issues.apache.org/jira/browse/TAJO-1284
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: catalog
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>         Attachments: TAJO-1260.png, TAJO-1260.sql, TAJO-1284.patch, 
> TAJO-1284_2.patch, TAJO-1284_2.png, TAJO-1284_2.sql
>
>
> This patch will implement  ALTER TABLE ADD PARTITION method and ALTER TABLE 
> DROP PARTITION method to CatalogStore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)