Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/473#issuecomment-87399705
  
    @hyunsik, thanks for the nice suggestion. It is definitely a better 
solution.
    However, I have a different opinion on detailed implementation. 
    The first option that initialize each function invocation implementation at 
the first function call is deprecated, so it is not a good choice.
    And the second option using EvalNode::Bind() seems to initialize 
schema-dependent variables. Even though we still can change the specification 
of TAJO-1436, the current one looks good. Since relations have different 
schemas, schema-dependent variables should be initialized for each schema. 
    
    However, function invocation implementation does not depend on relations' 
schema. I think that it would be better to initialize when an instance of 
```FunctionEval``` is created.
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to