Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/526#discussion_r28569644
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/function/FunctionLoader.java ---
    @@ -66,7 +80,48 @@
           }
         }
     
    -    return map.values();
    +    return map;
    +  }
    +
    +  /**
    +   * Load functions that are optionally defined by users.
    +   *
    +   * @param conf
    +   * @param functionMap
    +   * @return
    +   * @throws IOException
    +   */
    +  public static Map<FunctionSignature, FunctionDesc> 
loadOptionalFunctions(TajoConf conf,
    --- End diff --
    
    In my opinion, 'user-defined function' would be a better word than 
'optional function'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to