[ 
https://issues.apache.org/jira/browse/TAJO-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387630#comment-14387630
 ] 

ASF GitHub Bot commented on TAJO-1460:
--------------------------------------

Github user navis commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/474#discussion_r27442930
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
 ---
    @@ -168,7 +168,7 @@ private Path sortAndStoreChunk(int chunkId, List<Tuple> 
tupleBlock)
         int rowNum = tupleBlock.size();
     
         long sortStart = System.currentTimeMillis();
    -    Collections.sort(tupleBlock, getComparator());
    +    Iterable<Tuple> sorted = getSorter(tupleBlock).sort();
    --- End diff --
    
    Fixed that (some undoing seemed caused that) and changed the test. 


> Apply TAJO-1407 to ExternalSortExec
> -----------------------------------
>
>                 Key: TAJO-1460
>                 URL: https://issues.apache.org/jira/browse/TAJO-1460
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>
> Tipped by @Hyoungjun Kim. Seemed possible to apply easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to