[
https://issues.apache.org/jira/browse/TAJO-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390374#comment-14390374
]
ASF GitHub Bot commented on TAJO-1460:
--------------------------------------
Github user babokim commented on a diff in the pull request:
https://github.com/apache/tajo/pull/474#discussion_r27559826
--- Diff:
tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java ---
@@ -89,9 +89,9 @@ public TestJoinQuery(String joinOption) {
@Parameters
public static Collection<Object[]> generateParameters() {
return Arrays.asList(new Object[][]{
- {"Hash_NoBroadcast"},
--- End diff --
These parameterized test cases should be included.
Each query with different parameter returns different order of rows. Adding
additional order by column or order by clause can resolve this problem as the
following example:
testComplexJoinCondition7.sql
```
select
n1.n_nationkey,
n1.n_name,
n2.n_name
from nation n1 join (select * from nation union select * from nation) n2 on
substr(n1.n_name, 1, 4) = substr(n2.n_name, 1, 4)
order by n1.n_nationkey;
```
You can add "n2.n_name" column in where clause.
```
select
n1.n_nationkey,
n1.n_name,
n2.n_name
from nation n1 join (select * from nation union select * from nation) n2 on
substr(n1.n_name, 1, 4) = substr(n2.n_name, 1, 4)
order by n1.n_nationkey, n2.n_name;
```
> Apply TAJO-1407 to ExternalSortExec
> -----------------------------------
>
> Key: TAJO-1460
> URL: https://issues.apache.org/jira/browse/TAJO-1460
> Project: Tajo
> Issue Type: Improvement
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
>
> Tipped by @Hyoungjun Kim. Seemed possible to apply easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
