[ 
https://issues.apache.org/jira/browse/TAJO-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392303#comment-14392303
 ] 

ASF GitHub Bot commented on TAJO-1421:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/450#discussion_r27637718
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
 ---
    @@ -44,10 +45,16 @@
       protected Column addColumn = null; //optional
       @Expose
       protected PartitionDesc partitionDesc; //optional
    +  @Expose
    +  protected KeyValueSet properties;
     
       public AlterTableDesc() {
    +    this.properties = new KeyValueSet();
       }
     
    +  public AlterTableDesc(KeyValueSet properties) {
    --- End diff --
    
    It looks like an unnecessary constructor because it is not used.


> Add 'ALTER TABLE SET PROPERTY' statement
> ----------------------------------------
>
>                 Key: TAJO-1421
>                 URL: https://issues.apache.org/jira/browse/TAJO-1421
>             Project: Tajo
>          Issue Type: New Feature
>          Components: catalog, storage
>            Reporter: Hyunsik Choi
>            Assignee: Yongjin Choi
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1421.yongjin.patch, TAJO-1421_2.patch
>
>
> Each table has table properties. Currently, users can only set table 
> properties only when a table is created. But, in many cases, we need to 
> change table properties later.
> To allow users to change table properties of an existing table, I propose 
> 'ALTER TABLE SET PROPERTY' statement.
> The proposed grammar is as follow:
> {code}
> ALTER TABLE SET PROPERTY property_name = property_value, ..., property_name = 
> property_value;
> {code}
> {{property_name=property_value}} can be listed by comma chain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to