[
https://issues.apache.org/jira/browse/TAJO-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393892#comment-14393892
]
ASF GitHub Bot commented on TAJO-1421:
--------------------------------------
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/450#discussion_r27711220
--- Diff:
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
---
@@ -995,6 +995,10 @@ public void testAlterTableName () throws Exception {
TableDesc addColumnDesc =
catalog.getTableDesc("default","mynewcooltable");
assertTrue(addColumnDesc.getSchema().containsByName("mynewcol"));
+ //SET_PROPERTY
+ catalog.alterTable(createMockAlterTableSetProperty());
+ TableDesc setPropertyDesc =
catalog.getTableDesc("default","mynewcooltable");
+ assertEquals("GMT+0", setPropertyDesc.getMeta().getOption("timezone"));
--- End diff --
You already implemented an unit test case for this feature. But I suggest
for you to implement more unit test cases because you just used mockup table.
It would be more valuable if you verify the change status of TableDesc. Unit
test cases for partitioned table would be help for you to implement this.
> Add 'ALTER TABLE SET PROPERTY' statement
> ----------------------------------------
>
> Key: TAJO-1421
> URL: https://issues.apache.org/jira/browse/TAJO-1421
> Project: Tajo
> Issue Type: New Feature
> Components: catalog, storage
> Reporter: Hyunsik Choi
> Assignee: Yongjin Choi
> Fix For: 0.11.0
>
> Attachments: TAJO-1421.yongjin.patch, TAJO-1421_2.patch
>
>
> Each table has table properties. Currently, users can only set table
> properties only when a table is created. But, in many cases, we need to
> change table properties later.
> To allow users to change table properties of an existing table, I propose
> 'ALTER TABLE SET PROPERTY' statement.
> The proposed grammar is as follow:
> {code}
> ALTER TABLE SET PROPERTY property_name = property_value, ..., property_name =
> property_value;
> {code}
> {{property_name=property_value}} can be listed by comma chain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
