Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/450#discussion_r27711220
--- Diff:
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
---
@@ -995,6 +995,10 @@ public void testAlterTableName () throws Exception {
TableDesc addColumnDesc =
catalog.getTableDesc("default","mynewcooltable");
assertTrue(addColumnDesc.getSchema().containsByName("mynewcol"));
+ //SET_PROPERTY
+ catalog.alterTable(createMockAlterTableSetProperty());
+ TableDesc setPropertyDesc =
catalog.getTableDesc("default","mynewcooltable");
+ assertEquals("GMT+0", setPropertyDesc.getMeta().getOption("timezone"));
--- End diff --
You already implemented an unit test case for this feature. But I suggest
for you to implement more unit test cases because you just used mockup table.
It would be more valuable if you verify the change status of TableDesc. Unit
test cases for partitioned table would be help for you to implement this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
