DaeMyung Kang created TAJO-1548:
-----------------------------------

             Summary: Refactoring condition code for CHAR into CatalogUtil
                 Key: TAJO-1548
                 URL: https://issues.apache.org/jira/browse/TAJO-1548
             Project: Tajo
          Issue Type: Improvement
            Reporter: DaeMyung Kang
            Assignee: DaeMyung Kang
            Priority: Minor


Currently Schema's addColumn is this

```java
  public synchronized Schema addColumn(String name, Type type) {
    if (type == Type.CHAR) {
      return addColumn(name, CatalogUtil.newDataTypeWithLen(type, 1));
    }
    return addColumn(name, CatalogUtil.newSimpleDataType(type));
  }
```

I think it is better condition code into CatalogUtil.newSimpleDataType.
because some testcode make columns just using CatalogUtil.






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to