GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/531
TAJO-1548 Refactoring condition code for CHAR into CatalogUtil
Currently Schema's addColumn is this
```java
public synchronized Schema addColumn(String name, Type type) {
if (type == Type.CHAR)
{ return addColumn(name, CatalogUtil.newDataTypeWithLen(type, 1)); }
return addColumn(name, CatalogUtil.newSimpleDataType(type));
}
```
I think it is better condition code into CatalogUtil.newSimpleDataType.
because some testcode make columns just using CatalogUtil.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/TAJO-1548
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/531.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #531
----
commit 61ab939db276000f09d613635ab06f54a3be1963
Author: clark.kang <[email protected]>
Date: 2015-04-11T16:00:12Z
TAJO-1548
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
