Github user sirpkt commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/454#discussion_r28210446
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java ---
    @@ -491,14 +506,16 @@ public WindowSpec 
buildWindowSpec(SQLParser.Window_specificationContext ctx) {
         WindowFrameStartBoundType boundType = null;
         if (checkIfExist(context.UNBOUNDED())) {
           boundType = WindowFrameStartBoundType.UNBOUNDED_PRECEDING;
    -    } else if (checkIfExist(context.unsigned_value_specification())) {
    +    } else if (checkIfExist(context.PRECEDING())) {
           boundType = WindowFrameStartBoundType.PRECEDING;
    +    } else if (checkIfExist(context.FOLLOWING())) {
    +      boundType = WindowFrameStartBoundType.FOLLOWING;
         } else {
           boundType = WindowFrameStartBoundType.CURRENT_ROW;
    --- End diff --
    
    Oh, I wrongly set the default value of start bound.
    I think you mean that the default value of start bound should be UNBOUNDED 
PRECEDING, right?
    I'll change the default start boundType to UNBOUNDED PRECEDING.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to