Github user sirpkt commented on a diff in the pull request:
https://github.com/apache/tajo/pull/454#discussion_r28211157
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
---
@@ -678,8 +679,26 @@ public EvalNode visitGeneralSetFunction(Context ctx,
Stack<Expr> stack, GeneralS
}
}
+
public static final Set<String> WINDOW_FUNCTIONS =
- Sets.newHashSet("row_number", "rank", "dense_rank", "percent_rank",
"cume_dist", "first_value", "lag");
+ Sets.newHashSet("row_number", "rank", "dense_rank", "percent_rank",
"cume_dist", "ntile", "first_value", "last_value", "lag");
--- End diff --
It is because 'lead' function is implemented not as WindowAggFunc but as
AggFunction.
I think it should be re-implemented as WindowAggFunc
but it needs more consideration about handling of arguments and default
output value
so that I think it is better to handle as separate issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
