Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/531#issuecomment-94029362
Hi, @blrunner
CHAR type can have length. :)
But if we make CHAR Column using this command
in
tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestReadWrite.java
```java
columns.add(new Column("mychar", Type.CHAR));
```
but it's length is 0, because it is just using CatalogUtil.newSimpleDataType
and Scheme class already use condition code in addColumn method.
But I think it can cause some mistakes easily.
So I think it is better to move this condition code into
CatalogUtil.newSimpleDataType
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
