[
https://issues.apache.org/jira/browse/TAJO-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501156#comment-14501156
]
ASF GitHub Bot commented on TAJO-1570:
--------------------------------------
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/542
TAJO-1570 CatalogUtil newSimpleDataTypeArray should use newSimpleDataType
It is better CatalogUtil's newSimpleDataTypeArray method use
newSimpleDataType. Because their purpose is the same.
and it is efficient when someone change newSimpleDataType method.
```java
public static DataType [] newSimpleDataTypeArray(Type... types) {
DataType [] dataTypes = new DataType[types.length];
for (int i = 0; i < types.length; i++)
{ dataTypes[i] = DataType.newBuilder().setType(types[i]).build(); }
return dataTypes;
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/refactoring-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit 539069dab0c94b40c5d603059f1964b47a2c8d3f
Author: clark.kang <[email protected]>
Date: 2015-04-18T06:44:44Z
refactoring
----
> CatalogUtil newSimpleDataTypeArray should use newSimpleDataType
> ---------------------------------------------------------------
>
> Key: TAJO-1570
> URL: https://issues.apache.org/jira/browse/TAJO-1570
> Project: Tajo
> Issue Type: Improvement
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
>
> It is better CatalogUtil's newSimpleDataTypeArray method use
> newSimpleDataType. Because their purpose is the same.
> and it is efficient when someone change newSimpleDataType method.
> ```java
> public static DataType [] newSimpleDataTypeArray(Type... types) {
> DataType [] dataTypes = new DataType[types.length];
> for (int i = 0; i < types.length; i++) {
> dataTypes[i] = DataType.newBuilder().setType(types[i]).build();
> }
> return dataTypes;
> }
> ```
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
