[ 
https://issues.apache.org/jira/browse/TAJO-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501822#comment-14501822
 ] 

ASF GitHub Bot commented on TAJO-1570:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/542


> CatalogUtil newSimpleDataTypeArray should use newSimpleDataType
> ---------------------------------------------------------------
>
>                 Key: TAJO-1570
>                 URL: https://issues.apache.org/jira/browse/TAJO-1570
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>            Priority: Minor
>
> It is better CatalogUtil's newSimpleDataTypeArray method use 
> newSimpleDataType. Because their purpose is the same. 
> and it is efficient when someone change newSimpleDataType method.
> ```java
>    public static DataType [] newSimpleDataTypeArray(Type... types) {
>      DataType [] dataTypes = new DataType[types.length];
>      for (int i = 0; i < types.length; i++) {
>       dataTypes[i] = DataType.newBuilder().setType(types[i]).build();
>      }
>      return dataTypes;
>    }
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to