Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/454#discussion_r28643014
--- Diff:
tajo-core/src/test/java/org/apache/tajo/engine/query/TestWindowQuery.java ---
@@ -462,4 +462,148 @@ public final void testMultipleWindow() throws
Exception {
executeString("DROP TABLE multiwindow PURGE");
}
}
+
+ @Test
+ public final void testWindowFrame1() throws Exception {
--- End diff --
The tests ```testWindowFrame1```, ```testWindowFrame2```,
```testWindowFrame3```, and ```testWindowFrame4``` look good, but it would be
better if they are written in our test writing convention. That is separating
java codes, test queries, and results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
