Github user sirpkt commented on a diff in the pull request:
https://github.com/apache/tajo/pull/454#discussion_r28664769
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java ---
@@ -28,18 +28,28 @@
import org.apache.tajo.datum.Datum;
import org.apache.tajo.plan.function.AggFunction;
import org.apache.tajo.plan.function.FunctionContext;
-import org.apache.tajo.plan.logical.WindowSpec;
+import org.apache.tajo.plan.logical.LogicalWindowSpec;
import org.apache.tajo.storage.Tuple;
import org.apache.tajo.util.TUtil;
public class WindowFunctionEval extends AggregationFunctionCallEval
implements Cloneable {
@Expose private SortSpec [] sortSpecs;
- @Expose WindowSpec.WindowFrame windowFrame;
+ @Expose LogicalWindowSpec.LogicalWindowFrame logicalWindowFrame;
+ private Tuple params;
+
+ public static enum WindowFunctionType {
--- End diff --
You're right.
I'll remove the ```static```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
