[
https://issues.apache.org/jira/browse/TAJO-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501819#comment-14501819
]
ASF GitHub Bot commented on TAJO-1548:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/531#issuecomment-94269856
Hi @charsyam and @blrunner, thanks for your work.
As @charsyam said, ```CHAR``` type can have a variable length. The code in
```Schema::add()``` seems to give a default length for this type. I agree on
that this patch will reduce mistakes because many other codes use
```CatalogUtil.newSimpleDataType()``` directly.
> Refactoring condition code for CHAR into CatalogUtil
> ----------------------------------------------------
>
> Key: TAJO-1548
> URL: https://issues.apache.org/jira/browse/TAJO-1548
> Project: Tajo
> Issue Type: Improvement
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
>
> Currently Schema's addColumn is this
> ```java
> public synchronized Schema addColumn(String name, Type type) {
> if (type == Type.CHAR) {
> return addColumn(name, CatalogUtil.newDataTypeWithLen(type, 1));
> }
> return addColumn(name, CatalogUtil.newSimpleDataType(type));
> }
> ```
> I think it is better condition code into CatalogUtil.newSimpleDataType.
> because some testcode make columns just using CatalogUtil.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
