[
https://issues.apache.org/jira/browse/TAJO-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502280#comment-14502280
]
Hudson commented on TAJO-1548:
------------------------------
FAILURE: Integrated in Tajo-master-CODEGEN-build #319 (See
[https://builds.apache.org/job/Tajo-master-CODEGEN-build/319/])
TAJO-1548: Refactoring condition code for CHAR into CatalogUtil. (blrunner: rev
044fd49a157424aef658d20025a9be094ff25334)
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
* CHANGES
> Refactoring condition code for CHAR into CatalogUtil
> ----------------------------------------------------
>
> Key: TAJO-1548
> URL: https://issues.apache.org/jira/browse/TAJO-1548
> Project: Tajo
> Issue Type: Improvement
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
> Fix For: 0.11.0
>
>
> Currently Schema's addColumn is this
> ```java
> public synchronized Schema addColumn(String name, Type type) {
> if (type == Type.CHAR) {
> return addColumn(name, CatalogUtil.newDataTypeWithLen(type, 1));
> }
> return addColumn(name, CatalogUtil.newSimpleDataType(type));
> }
> ```
> I think it is better condition code into CatalogUtil.newSimpleDataType.
> because some testcode make columns just using CatalogUtil.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
