Github user sirpkt commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/454#discussion_r28664862
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/engine/query/TestWindowQuery.java ---
    @@ -462,4 +462,148 @@ public final void testMultipleWindow() throws 
Exception {
           executeString("DROP TABLE multiwindow PURGE");
         }
       }
    +
    +  @Test
    +  public final void testWindowFrame1() throws Exception {
    --- End diff --
    
    You're right, @jihoonson.
    I'll separate codes, queries, and results.
    
    By the way, in other part of Tajo code, 
    there exists test codes like what I did (for example, testJoinQuery, 
testJoinBroadcast, ...).
    I think we need overall refactoring of test code to make them follow our 
test writing convention.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to