Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/485#discussion_r29142927
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
---
@@ -36,35 +36,24 @@
* ascending or descending order of partition columns.
*/
public class SortBasedColPartitionStoreExec extends ColPartitionStoreExec {
- private Tuple currentKey;
- private Tuple prevKey;
+
+ private ComparableTuple prevKey;
public SortBasedColPartitionStoreExec(TaskAttemptContext context,
StoreTableNode plan, PhysicalExec child)
throws IOException {
super(context, plan, child);
}
- public void init() throws IOException {
- super.init();
-
- currentKey = new VTuple(keyNum);
- }
-
- private void fillKeyTuple(Tuple inTuple, Tuple keyTuple) {
- for (int i = 0; i < keyIds.length; i++) {
- keyTuple.put(i, inTuple.get(keyIds[i]));
- }
- }
+ private transient StringBuilder sb = new StringBuilder();
private String getSubdirectory(Tuple keyTuple) {
--- End diff --
Input tuple seems not to be a key tuple anymore. Please change its name,
too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
