Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/485#issuecomment-96644896
Hi @navis. Your patch looks good to me. I left only a single trivial
comment.
Additionally, I have a question about ```TupleType``` even though this is
not related to this patch. Obviously, ```TupleType``` represents the data type
rather than tuple type (even I have no idea what tuple type means). I wonder
why you don't use just ```TajoDataTypes.Type```.
Finally, truly sorry for late review, but would you rebase your patches? We
have resolved the problem of jvm crash at
https://issues.apache.org/jira/browse/TAJO-1568. If you trigger CI by rebasing
your patches, it is definitely helpful for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
