[
https://issues.apache.org/jira/browse/TAJO-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514096#comment-14514096
]
ASF GitHub Bot commented on TAJO-1484:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/485#issuecomment-96644896
Hi @navis. Your patch looks good to me. I left only a single trivial
comment.
Additionally, I have a question about ```TupleType``` even though this is
not related to this patch. Obviously, ```TupleType``` represents the data type
rather than tuple type (even I have no idea what tuple type means). I wonder
why you don't use just ```TajoDataTypes.Type```.
Finally, truly sorry for late review, but would you rebase your patches? We
have resolved the problem of jvm crash at
https://issues.apache.org/jira/browse/TAJO-1568. If you trigger CI by rebasing
your patches, it is definitely helpful for review.
> Apply on ColPartitionStoreExec
> ------------------------------
>
> Key: TAJO-1484
> URL: https://issues.apache.org/jira/browse/TAJO-1484
> Project: Tajo
> Issue Type: Sub-task
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: TAJO-1484.1.patch.txt
>
>
> For simple demonstration of the intention. I'll apply to all execs when
> TAJO-1460 is included in master branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
