[
https://issues.apache.org/jira/browse/TAJO-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514073#comment-14514073
]
ASF GitHub Bot commented on TAJO-1484:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/485#discussion_r29142927
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
---
@@ -36,35 +36,24 @@
* ascending or descending order of partition columns.
*/
public class SortBasedColPartitionStoreExec extends ColPartitionStoreExec {
- private Tuple currentKey;
- private Tuple prevKey;
+
+ private ComparableTuple prevKey;
public SortBasedColPartitionStoreExec(TaskAttemptContext context,
StoreTableNode plan, PhysicalExec child)
throws IOException {
super(context, plan, child);
}
- public void init() throws IOException {
- super.init();
-
- currentKey = new VTuple(keyNum);
- }
-
- private void fillKeyTuple(Tuple inTuple, Tuple keyTuple) {
- for (int i = 0; i < keyIds.length; i++) {
- keyTuple.put(i, inTuple.get(keyIds[i]));
- }
- }
+ private transient StringBuilder sb = new StringBuilder();
private String getSubdirectory(Tuple keyTuple) {
--- End diff --
Input tuple seems not to be a key tuple anymore. Please change its name,
too.
> Apply on ColPartitionStoreExec
> ------------------------------
>
> Key: TAJO-1484
> URL: https://issues.apache.org/jira/browse/TAJO-1484
> Project: Tajo
> Issue Type: Sub-task
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: TAJO-1484.1.patch.txt
>
>
> For simple demonstration of the intention. I'll apply to all execs when
> TAJO-1460 is included in master branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
