Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/618#issuecomment-118631499
  
    Hi @jihoonson 
    
    Thanks for your detailed review. I updated the patch using your comments a 
few days ago.
    And I tested the partition location rule for hive. When adding partition on 
managed table or external table in hive, if the partition's directory doesn't 
exist, hive make the directory by force. And when dropping partition on managed 
table, hive will remove the directory by force, But when dropping partition on 
external table, hive will not remove the directory. If users want to remove the 
directory with drop partition statement, they need to specify PURGE option. It 
seems good to me because tajo partition had been made in reference to hive 
partition. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to