Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/618#issuecomment-118793127
  
    @blrunner, I have some more comments as follows.
    * The error message should be improved when the given column is not a 
partition key. Here is an example.
    ```
    default> alter table partitioned_nation add partition (n_comment=1, 
n_nationkey=2) location 
'hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation/col1=test/col2=2';
    ERROR: n_comment
    ```
    
    * I wonder that what will happen when an ```add partition``` statement is 
executed with the already existing location as follows.
    * The ```add partition``` statement does not create the full path of 
partition as follows.
    ```
    default> alter table partitioned_nation add partition (n_regionkey=1, 
n_nationkey=2) location 
'hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation/col1=test/col2=2';
    OK
    default> \dfs -ls 
hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation/col1=test
    default> 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to