[ 
https://issues.apache.org/jira/browse/TAJO-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641359#comment-14641359
 ] 

ASF GitHub Bot commented on TAJO-1681:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/628#discussion_r35478801
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java ---
    @@ -64,4 +64,15 @@ public void testDump2() throws Exception {
           executeString("DROP TABLE \"" + getCurrentDatabase() + 
"\".\"TableName2\"");
         }
       }
    +
    +   @Test
    +   public void testDump3() throws Exception {
    +           if (!testingCluster.isHiveCatalogStoreRunning()) {
    +                   UserRoleInfo userInfo = UserRoleInfo.getCurrentUser();
    +                   ByteArrayOutputStream bos = new ByteArrayOutputStream();
    +                   PrintWriter printWriter = new PrintWriter(bos);
    +
    +                   TajoDump.dump(client, userInfo, null, false, false, 
false, printWriter);
    --- End diff --
    
    It would be nice if the dump result is verified. Please refer to other 
tests in this class.


> Fix TajoDump invalid null check for database name
> -------------------------------------------------
>
>                 Key: TAJO-1681
>                 URL: https://issues.apache.org/jira/browse/TAJO-1681
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>
> TajoDump invalid null check in isAcceptableDumpingDatabase



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to