[ 
https://issues.apache.org/jira/browse/TAJO-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641976#comment-14641976
 ] 

ASF GitHub Bot commented on TAJO-1681:
--------------------------------------

Github user charsyam commented on the pull request:

    https://github.com/apache/tajo/pull/628#issuecomment-124997712
  
    @jihoonson Thanks your review :), Yes, I think It is good idea.
    but I still have a question about this behavior :)
    
    Because isAcceptableDumpingDatabase's return value doesn't mean error.
    it jsut check database name is not 
CatalogConstants.INFORMATION_SCHEMA_DB_NAME
    
    What do you think?
    but I found indent is wrong T.T I should fix it first :)
    
    
    
     



> Fix TajoDump invalid null check for database name
> -------------------------------------------------
>
>                 Key: TAJO-1681
>                 URL: https://issues.apache.org/jira/browse/TAJO-1681
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>
> TajoDump invalid null check in isAcceptableDumpingDatabase



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to