[
https://issues.apache.org/jira/browse/TAJO-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648868#comment-14648868
]
ASF GitHub Bot commented on TAJO-1699:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/662#discussion_r35951917
--- Diff: tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
---
@@ -108,17 +111,17 @@
TajoMemoryResultSet fetchNextQueryResult(final QueryId queryId, final
int fetchRowNum) throws SQLException;
- boolean updateQuery(final String sql) throws SQLException;
+ boolean updateQuery(final String sql) throws TajoException;
- boolean updateQueryWithJson(final String json) throws SQLException;
+ boolean updateQueryWithJson(final String json) throws TajoException;
List<ClientProtos.BriefQueryInfo> getRunningQueryList() throws
SQLException;
--- End diff --
Some of other methods in this class still throw ```SQLException```. Is it
good or do you leave them for future changes?
> Tajo Java Client version 2
> --------------------------
>
> Key: TAJO-1699
> URL: https://issues.apache.org/jira/browse/TAJO-1699
> Project: Tajo
> Issue Type: Improvement
> Components: Java Client
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> I propose Tajo Java Client version 2. Its motivations are as follows:
> * After TAJO-1625, the error propagation has been changed significantly.
> Java Client should make use the new error propagation system. Java Client
> should throw the proper exceptions.
> * Many Java API exposes internal data structure and protocol buffer data
> structure. It requires users to understand its internal behavior and
> architecture. We should hide them from users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
