[ 
https://issues.apache.org/jira/browse/TAJO-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648879#comment-14648879
 ] 

ASF GitHub Bot commented on TAJO-1699:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/662#discussion_r35952542
  
    --- Diff: 
tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDeligateFactory.java 
---
    @@ -0,0 +1,42 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.client.v2;
    +
    +import org.apache.tajo.annotation.Nullable;
    +import org.apache.tajo.client.v2.exception.ClientUnableToConnectException;
    +
    +import java.util.Map;
    +
    +public class ClientDeligateFactory {
    +
    +  public static ClientDelegate newDefaultDeligate(String host,
    +                                                  int port,
    +                                                  @Nullable Map<String, 
String> props)
    +      throws ClientUnableToConnectException {
    +
    +    return new LegacyClientDelegate(host, port, props);
    +  }
    +
    +  public static ClientDelegate newDefaultDeligate(ServiceDiscovery 
discovery,
    --- End diff --
    
    Please fix typo.


> Tajo Java Client version 2
> --------------------------
>
>                 Key: TAJO-1699
>                 URL: https://issues.apache.org/jira/browse/TAJO-1699
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Java Client
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> I propose Tajo Java Client version 2. Its motivations are as follows:
>  * After TAJO-1625, the error propagation has been changed significantly. 
> Java Client should make use the new error propagation system. Java Client 
> should throw the proper exceptions.
>  * Many Java API exposes internal data structure and protocol buffer data 
> structure. It requires users to understand its internal behavior and 
> architecture. We should hide them from users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to