[ 
https://issues.apache.org/jira/browse/TAJO-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725077#comment-14725077
 ] 

ASF GitHub Bot commented on TAJO-1803:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/714#discussion_r38401421
  
    --- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java 
---
    @@ -26,9 +26,11 @@
     import org.apache.tajo.TajoConstants;
     import org.apache.tajo.TajoProtos.QueryState;
     import org.apache.tajo.TajoTestingCluster;
    +import org.apache.tajo.catalog.CatalogConstants;
    --- End diff --
    
    unused imports


> Use in-memory derby as the default catalog for unit tests
> ---------------------------------------------------------
>
>                 Key: TAJO-1803
>                 URL: https://issues.apache.org/jira/browse/TAJO-1803
>             Project: Tajo
>          Issue Type: Task
>          Components: Unit Test
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.11.0
>
>
> We are currently using MemStore which is designed to provide the same 
> interface with AbstractDBStore. This incurs two problems.
> * The major problem is that AbstractDBStore is not tested properly by unit 
> testing. The logic to access catalog is separated into MemStore and 
> AbstractDBStore, and only MemStore is tested.
> * We have to implement both AbstractDBStore and MemStore whenever we modify 
> the catalog interface even though MemStore is used only in unit testing. This 
> is an unnecessary burden to developers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to