[ 
https://issues.apache.org/jira/browse/TAJO-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725084#comment-14725084
 ] 

ASF GitHub Bot commented on TAJO-1803:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/714#discussion_r38402086
  
    --- Diff: tajo-common/src/main/proto/errors.proto ---
    @@ -157,6 +157,9 @@ enum ResultCode {
       CAT_UPGRADE_REQUIRED                  = 901;  // Migration
       CAT_CANNOT_CONNECT                    = 902;  // Cannot connect metadata 
server
     
    +  // Catalog store
    +  UNSUPPORTED_CATALOG_STORE             = 905; // Unsupported type of 
catalog store
    --- End diff --
    
    It seems to be necessary the prefix ``CAT``.


> Use in-memory derby as the default catalog for unit tests
> ---------------------------------------------------------
>
>                 Key: TAJO-1803
>                 URL: https://issues.apache.org/jira/browse/TAJO-1803
>             Project: Tajo
>          Issue Type: Task
>          Components: Unit Test
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.11.0
>
>
> We are currently using MemStore which is designed to provide the same 
> interface with AbstractDBStore. This incurs two problems.
> * The major problem is that AbstractDBStore is not tested properly by unit 
> testing. The logic to access catalog is separated into MemStore and 
> AbstractDBStore, and only MemStore is tested.
> * We have to implement both AbstractDBStore and MemStore whenever we modify 
> the catalog interface even though MemStore is used only in unit testing. This 
> is an unnecessary burden to developers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to