[
https://issues.apache.org/jira/browse/TAJO-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726824#comment-14726824
]
Tajo QA commented on TAJO-1809:
-------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753684/TAJO-1809.patch
against master revision release-0.9.0-rc0-434-g2c9305a.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 3 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 28 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests.{color} The patch failed these unit tests in
tajo-common tajo-core tajo-core-tests tajo-plan:
org.apache.tajo.ws.rs.resources.TestDatabasesResource
org.apache.tajo.ha.TestHAServiceHDFSImpl
org.apache.tajo.engine.query.TestCrossJoin
org.apache.tajo.engine.query.TestMultipleJoinTypes
org.apache.tajo.client.TestCatalogAdminClientExceptions
org.apache.tajo.engine.query.TestDropTable
org.apache.tajo.engine.function.TestJsonFunctions
org.apache.tajo.engine.query.TestCommonConditionReduce
org.apache.tajo.engine.function.TestConditionalExpressions
org.apache.tajo.engine.query.TestWindowQuery
org.apache.tajo.engine.planner.physical.TestSortExec
org.apache.tajo.engine.function.TestFunctionLoader
org.apache.tajo.engine.function.TestStringOperatorsAndFunctions
org.apache.tajo.engine.query.TestAlterTable
org.apache.tajo.engine.query.TestCreateTable
org.apache.tajo.cli.tsql.TestTajoCli
org.apache.tajo.engine.query.TestUnionQuery
org.apache.tajo.engine.query.TestTableSubQuery
org.apache.tajo.engine.query.TestAlterTablespace
org.apache.tajo.engine.query.TestSetSessionQuery
org.apache.tajo.benchmark.TestTPCH
org.apache.tajo.engine.query.TestOuterJoinQuery
org.apache.tajo.engine.eval.TestSQLDateTimeTypes
org.apache.tajo.ws.rs.resources.TestQueryResultResource
org.apache.tajo.engine.query.TestInnerJoinWithSubQuery
org.apache.tajo.engine.eval.TestEvalTree
org.apache.tajo.engine.planner.TestQueryValidation
org.apache.tajo.cli.tsql.commands.TestExecExternalShellCommand
org.apache.tajo.engine.function.TestDateTimeFunctions
org.apache.tajo.engine.query.TestGroupByQuery
org.apache.tajo.client.v2.TestTajoClientV2
org.apache.tajo.client.TestQueryClientExceptions
org.apache.tajo.ws.rs.resources.TestTablesResource
org.apache.tajo.ws.rs.resources.TestSessionsResource
org.apache.tajo.engine.query.TestTablePartitions
org.apache.tajo.cli.tools.TestTajoDump
org.apache.tajo.engine.query.TestSelectNestedRecord
org.apache.tajo.ws.rs.resources.TestClusterResource
org.apache.tajo.engine.query.TestCaseByCases
org.apache.tajo.engine.function.TestPatternMatchingPredicates
org.apache.tajo.client.TestTajoClient
org.apache.tajo.querymaster.TestTaskStatusUpdate
org.apache.tajo.querymaster.TestQueryState
org.apache.tajo.engine.query.TestInsertQuery
org.apache.tajo.engine.query.TestCTASQuery
org.apache.tajo.cli.tsql.TestDefaultCliOutputFormatter
org.apache.tajo.engine.eval.TestIntervalType
org.apache.tajo.ws.rs.resources.TestFunctionsResource
org.apache.tajo.engine.function.TestMathFunctions
org.apache.tajo.engine.query.TestHBaseTable
org.apache.tajo.engine.codegen.TestEvalCodeGenerator
org.apache.tajo.engine.query.TestSimpleQuery
org.apache.tajo.engine.planner.TestPlannerUtil
org.apache.tajo.engine.query.TestCreateDatabase
org.apache.tajo.util.history.TestHistoryWriterReader
org.apache.tajo.querymaster.TestKillQuery
org.apache.tajo.engine.function.TestBuiltinFunctions
org.apache.tajo.engine.eval.TestPredicates
org.apache.tajo.engine.query.TestNullValues
org.apache.tajo.engine.function.TestPythonFunctions
org.apache.tajo.ws.rs.resources.TestQueryResource
org.apache.tajo.engine.query.TestOuterJoinWithSubQuery
org.apache.tajo.engine.query.TestNetTypes
org.apache.tajo.master.TestNonForwardQueryResultSystemScanner
org.apache.tajo.engine.query.TestIndexScan
org.apache.tajo.engine.query.TestSelectQuery
org.apache.tajo.engine.query.TestTruncateTable
org.apache.tajo.engine.eval.TestSQLExpression
org.apache.tajo.engine.query.TestCreateIndex
org.apache.tajo.engine.query.TestSortQuery
org.apache.tajo.engine.query.TestInSubquery
org.apache.tajo.engine.query.TestInnerJoinQuery
org.apache.tajo.querymaster.TestQueryProgress
org.apache.tajo.cli.tsql.TestTajoCliNegatives
org.apache.tajo.cli.tsql.commands.TestHdfsCommand
org.apache.tajo.engine.query.TestJoinOnPartitionedTables
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/832//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/832//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/832//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/832//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/832//console
This message is automatically generated.
> Change default value of several configurations
> ----------------------------------------------
>
> Key: TAJO-1809
> URL: https://issues.apache.org/jira/browse/TAJO-1809
> Project: Tajo
> Issue Type: Task
> Components: conf and scripts
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Fix For: 0.11.0
>
> Attachments: TAJO-1809.patch
>
>
> Tajo has many configurations. For the sake of user convenience, they all have
> some default value. Most of default values make sense, but some are not. Here
> is my idea.
> * Tajo can choose hash-based algorithm and disk-based algorithm according to
> the remaining resource and query workload. Here, users can give a hint using
> session variables whose name is HASH_*_SIZE_LIMIT. Their current default
> value is 256 MB, but it's too large thereby incurring GC so often, and even
> OOM sometimes.
> * Query cache should be disabled by default. It will not be commonly used.
> * Configurations for broadcast join should accept numbers in MB.
> * Some configurations allow different unit in tajo-site.xml and session
> variable. This must be consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
