[ 
https://issues.apache.org/jira/browse/TAJO-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727006#comment-14727006
 ] 

Tajo QA commented on TAJO-1809:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12753713/TAJO-1809_2.patch
  against master revision release-0.9.0-rc0-434-g2c9305a.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 3 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 28 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-common tajo-core tajo-core-tests tajo-plan.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/836//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/836//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/836//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/836//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/836//console

This message is automatically generated.

> Change default value of several configurations
> ----------------------------------------------
>
>                 Key: TAJO-1809
>                 URL: https://issues.apache.org/jira/browse/TAJO-1809
>             Project: Tajo
>          Issue Type: Task
>          Components: conf and scripts
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1809.patch, TAJO-1809_2.patch
>
>
> Tajo has many configurations. For the sake of user convenience, they all have 
> some default value. Most of default values make sense, but some are not. Here 
> is my idea.
> * Tajo can choose hash-based algorithm and disk-based algorithm according to 
> the remaining resource and query workload. Here, users can give a hint using 
> session variables whose name is HASH_*_SIZE_LIMIT. Their current default 
> value is 256 MB, but it's too large thereby incurring GC so often, and even 
> OOM sometimes.
> * Query cache should be disabled by default. It will not be commonly used.
> * Configurations for broadcast join should accept numbers in MB. 
> * Some configurations allow different unit in tajo-site.xml and session 
> variable. This must be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to