[ 
https://issues.apache.org/jira/browse/TAJO-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730472#comment-14730472
 ] 

ASF GitHub Bot commented on TAJO-1730:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/719#discussion_r38728750
  
    --- Diff: 
tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/ConnectionInfo.java
 ---
    @@ -0,0 +1,112 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.storage.jdbc;
    +
    +import org.apache.tajo.exception.TajoInternalError;
    +
    +import java.net.URI;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +public class ConnectionInfo {
    +  String scheme;
    +  String dbName;
    +  String tableName;
    +  String user;
    +  String password;
    +  Map<String, String> params;
    +
    +  public String scheme() {
    +    return scheme;
    +  }
    +
    +  public String database() {
    +    return dbName;
    +  }
    +
    +  public String table() {
    +    return tableName;
    +  }
    +
    +  public String user() {
    +    return user;
    +  }
    +
    +  public String password() {
    +    return password;
    +  }
    +
    +  public static ConnectionInfo fromURI(String originalUri) {
    +    return fromURI(URI.create(originalUri));
    +  }
    +
    +  public static ConnectionInfo fromURI(URI originalUri) {
    +    final String uriStr = originalUri.toASCIIString();
    +    URI uri = originalUri;
    +
    +    final ConnectionInfo connInfo = new ConnectionInfo();
    +    connInfo.scheme = uriStr.substring(0, uriStr.indexOf("://"));
    --- End diff --
    
    Actually, URI format we used here is not standard format. So, this method 
needs its own code. Thanks.


> JDBC Tablespace support
> -----------------------
>
>                 Key: TAJO-1730
>                 URL: https://issues.apache.org/jira/browse/TAJO-1730
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1730.patch, TAJO-1730_2.patch, TAJO-1730_3.patch
>
>
> The main objective of this issue is to implement JDBC-based storage and its 
> Tablespace implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to