[ 
https://issues.apache.org/jira/browse/TAJO-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730477#comment-14730477
 ] 

ASF GitHub Bot commented on TAJO-1730:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/719#discussion_r38729200
  
    --- Diff: 
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
 ---
    @@ -93,21 +94,13 @@ public void storageInit() throws IOException {
         hbaseConf.set(HConstants.ZOOKEEPER_CLIENT_PORT, splits[1]);
       }
     
    -  @Override
    -  public void setConfig(String name, String value) {
    -  }
    -
    -  @Override
    -  public void setConfigs(Map<String, String> configs) {
    -  }
    -
       public Configuration getHbaseConf() {
         return hbaseConf;
       }
     
       @Override
    -  public long getTableVolume(URI uri) throws IOException {
    -    return 0;
    +  public long getTableVolume(URI uri) throws UnsupportedException {
    +    throw new UnsupportedException();
    --- End diff --
    
    Yes, you are right. NotImplementedException should be thrown when we will 
implement later. 
    I found a workaround to get the total volume of hbase table, that is using 
the HDFS command ```hadoop fs -du```. This will be inefficient, but may be very 
helpful for query planning. So, I think we need to implement this function 
someday. What do you think?


> JDBC Tablespace support
> -----------------------
>
>                 Key: TAJO-1730
>                 URL: https://issues.apache.org/jira/browse/TAJO-1730
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1730.patch, TAJO-1730_2.patch, TAJO-1730_3.patch
>
>
> The main objective of this issue is to implement JDBC-based storage and its 
> Tablespace implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to