[ 
https://issues.apache.org/jira/browse/TAJO-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742127#comment-14742127
 ] 

ASF GitHub Bot commented on TAJO-1465:
--------------------------------------

Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/652#discussion_r39339177
  
    --- Diff: tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java 
---
    @@ -333,7 +330,7 @@ public static DateDatum createDate(Datum datum) {
         case DATE:
           return (DateDatum) datum;
         default:
    -      throw new InvalidCastException(datum.type(), Type.DATE);
    +      throw new TajoRuntimeException(Errors.ResultCode.INVALID_CAST, 
datum.type().toString(), Type.DATE.name());
    --- End diff --
    
    @hyunsik 
    InvalidCastException is not subclass of TajoException, thus it can be used.
    Should it be changed?


> Add ORCFileAppender to write into ORCFile table
> -----------------------------------------------
>
>                 Key: TAJO-1465
>                 URL: https://issues.apache.org/jira/browse/TAJO-1465
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Storage
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Jongyoung Park
>              Labels: orc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to