[
https://issues.apache.org/jira/browse/TAJO-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746969#comment-14746969
]
ASF GitHub Bot commented on TAJO-1730:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/719#issuecomment-140642251
The latest patch looks good to me! Thank you for quick update.
I have two more comments.
First, as you know, there is a problem of precision of floating numbers. We
can simply ignore this problem until we support decimal or numeric types.
Second, I think that it would be nicer and easier to comprehend the overall
logic related to tablespace if you separate its implementation. More
specifically, in the current implementation, Tablespace is a single class, and
contains information about itself and provides some functionalities to interact
with underlying storage. This makes the implementation quite complicated. So,
how about separating it into Tablespace and TablespaceHandler? I'm just
suggesting you, and you don't have to do it in this ticket even though you
agree. Maybe it causes huge changes.
> JDBC Tablespace support
> -----------------------
>
> Key: TAJO-1730
> URL: https://issues.apache.org/jira/browse/TAJO-1730
> Project: Tajo
> Issue Type: Improvement
> Components: Storage
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
> Attachments: TAJO-1730.patch, TAJO-1730_2.patch, TAJO-1730_3.patch
>
>
> The main objective of this issue is to implement JDBC-based storage and its
> Tablespace implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
