Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/772#discussion_r39946738
--- Diff:
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java
---
@@ -172,7 +172,15 @@ PartitionDescProto getPartition(String databaseName,
String tableName, String pa
throws UndefinedPartitionException,
UndefinedPartitionMethodException, UndefinedDatabaseException,
UndefinedTableException;
- List<PartitionDescProto> getPartitions(String databaseName, String
tableName);
+ List<PartitionDescProto> getAllPartitions(String databaseName, String
tableName) throws UndefinedDatabaseException,
+ UndefinedTableException, UndefinedPartitionMethodException,
PartitionNotFoundException;
+
+ List<PartitionDescProto> getPartitionsByAlgebra(PartitionsByAlgebraProto
request) throws
+ UndefinedDatabaseException, UndefinedTableException,
UndefinedPartitionMethodException,
+ PartitionNotFoundException, UnsupportedException;
+
+ List<PartitionDescProto> getPartitionsByFilter(PartitionsByFilterProto
request) throws
--- End diff --
IMO, this method must not throw PartitionNotFoundException, but return an
empty list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
