Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/772#discussion_r40093053
--- Diff:
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
---
@@ -812,16 +812,34 @@ public static AlterTableDesc setProperty(String
tableName, KeyValueSet params, A
/**
* Converts passed parameters to a AlterTableDesc. This method would be
called when adding a partition or dropping
* a table. This creates AlterTableDesc that is a wrapper class for
protocol buffer.
+ * *
+ * @param tableName
+ * @param columns
+ * @param values
+ * @param path
+ * @param alterTableType
+ * @return
+ */
+ public static AlterTableDesc addOrDropPartition(String tableName,
String[] columns,
+ String[] values,
@Nullable String path, AlterTableType
+ alterTableType) {
+
+ return addOrDropPartition(tableName, columns, values, path,
alterTableType, 0L);
+ }
+ /**
+ * Converts passed parameters to a AlterTableDesc. This method would be
called when adding a partition or dropping
+ * a table. This creates AlterTableDesc that is a wrapper class for
protocol buffer.
*
* @param tableName table name
* @param columns partition column names
* @param values partition values
- * @param location partition location
+ * @param path partition directory path
* @param alterTableType ADD_PARTITION or DROP_PARTITION
+ * @param numBytes contents length
* @return AlterTableDesc
*/
public static AlterTableDesc addOrDropPartition(String tableName,
String[] columns,
- String[] values, String
location, AlterTableType alterTableType) {
+ String[] values, @Nullable String path, AlterTableType
alterTableType, long numBytes) {
--- End diff --
Please fix indentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
